Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(glean): add page's UTM parameters to pings #9595

Merged
merged 3 commits into from
Oct 16, 2023
Merged

chore(glean): add page's UTM parameters to pings #9595

merged 3 commits into from
Oct 16, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Sep 1, 2023

Summary

https://mozilla-hub.atlassian.net/browse/MP-545
https://bugzilla.mozilla.org/show_bug.cgi?id=1851150

Problem

We can't easily attribute traffic which adds utm parameters through Glean.

Solution

Add utm parameters to our Glean pings.


How did you test this change?

@fiji-flo after sending this ping, I realised we already sorta send utm parameters to glean, through the page.path metric - since we'll now be sending these in a structured form, should I wipe utm_ parameters out of the url we send in that metric (or even not send any query parameters in page.path at all, to keep it "clean"?)

@LeoMcA LeoMcA requested a review from fiji-flo September 1, 2023 16:35
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@LeoMcA LeoMcA requested review from a team and removed request for fiji-flo October 11, 2023 09:45
@github-actions github-actions bot added metrics and removed merge conflicts 🚧 Please rebase onto or merge the latest main. labels Oct 16, 2023
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

client/src/telemetry/glean-context.tsx Outdated Show resolved Hide resolved
@LeoMcA
Copy link
Member Author

LeoMcA commented Oct 16, 2023

@fiji-flo after sending this ping, I realised we already sorta send utm parameters to glean, through the page.path metric - since we'll now be sending these in a structured form, should I wipe utm_ parameters out of the url we send in that metric (or even not send any query parameters in page.path at all, to keep it "clean"?)

@fiji-flo I have a vague memory of discussing this and you saying to clean the page.path metric, but I don't remember for sure (and couldn't find a record of it). I'll merge this for now, and can open another PR doing that if we want to do that.

@LeoMcA LeoMcA merged commit 4c72586 into main Oct 16, 2023
15 checks passed
@LeoMcA LeoMcA deleted the glean-utm branch October 16, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants