Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(baseline): not appearing on translated docs #9662

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix(baseline): not appearing on translated docs #9662

merged 2 commits into from
Oct 18, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Sep 14, 2023

Summary

https://mozilla-hub.atlassian.net/browse/MP-577

Problem

  • Baseline statues were not appearing on translated documents
  • translated documents also weren't getting a browserCompat key in their index.json/metadata.json

Solution

  • Use merged translated document and original document metadata

Screenshots

Before

image

After

image

@LeoMcA
fix(baseline): not appearing on translated docs
3279ea3 
also fixes translated docs not having a `browserCompat` key in their
index/metadata.json
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 14, 2023
@LeoMcA LeoMcA requested review from a team and removed request for fiji-flo October 11, 2023 09:45
@caugner caugner self-assigned this Oct 13, 2023
caugner
caugner requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, otherwise LGTM.

build/index.ts Show resolved Hide resolved
build/index.ts Outdated Show resolved Hide resolved
kumascript/index.ts Show resolved Hide resolved
@LeoMcA LeoMcA requested a review from caugner October 16, 2023 11:45
@LeoMcA LeoMcA merged commit 788c883 into main Oct 18, 2023
14 checks passed
@LeoMcA LeoMcA deleted the locale-bcd branch October 18, 2023 13:51
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees

@caugner caugner

Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoMcA @caugner