feat(blog): add toc #9707
Merged
feat(blog): add toc #9707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoMcA
approved these changes
Sep 21, 2023
Comment on lines
+199
to
+203
| <aside className="toc"> | ||
| <nav> | ||
| {doc.toc && !!doc.toc.length && <TOC toc={doc.toc} />} | ||
| </nav> | ||
| </aside> |
There was a problem hiding this comment.
Do we want all of this to be conditional on doc.toc && !!doc.toc.length, or do this aside and nav need to be here permanently for the css to work with the placement properly?
There was a problem hiding this comment.
That's a copy of the article toc. And I'm already touching to many things here, sorry.
caugner
requested changes
Sep 22, 2023
caugner
requested changes
Sep 22, 2023
Only for large screens for now. This also refactors the useStickyHeaderHeight hook.
Co-authored-by: Leo McArdle <lmcardle@mozilla.com>
caugner
requested changes
Sep 28, 2023
|
Sorry I fixed that now. |
Avoids sidebar being inside the main-page-content, to be consistent with document pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Display a ToC on blog posts.
This also refactors the useStickyHeaderHeight hook.
Problem
Hard to navigate long blog posts.
Solution
Reuse the ToC component with some tweaks.
Screenshots
Before
After
How did you test this change?
Locally