-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run github actions on mdolab docker images #434
Conversation
For reasons I'm clearly too stupid to understand, GitHub actions can only run in a docker container if they run as the root user in the container (see actions/checkout#1014 and actions/checkout#956). This doesn't work for our docker containers because we install things under the The only option I see if we want to run OAS's CI on our docker images is to migrate it to using Azure. Any other ideas @eirikurj ? |
@eirikurj do we need to merge this PR first before we can add OpenAeroStruct as a pipeline on azure? I'm trying to add it now but it needs an azure config yaml file to point to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree that moving testing to our docker containers is the way to go. I can add an Azure pipeline, but it will need to depend on this branch if you want to test it, and once merged we need to change it to main. Let me know what you prefer.
Will that work given that this PR is from my fork? If so then yes let's do that to make sure it works |
No, the branch needs to be on under the mdolab account to have access to it. |
OK, are you able to make a copy of this branch on the mdolab fork then? I don't have the permissions to do it |
Hmm, strange MDO Lab member only have triage permissions, but we typically have write for members. Not sure why, but we can discuss this during next maintenance meeting. New branch is here https://github.com/mdolab/OpenAeroStruct/tree/GHAImprovement |
Thanks, closing now as this is superseded by #438 |
Purpose
The current github action for running the OAS tests is a bit of a mess, it tries to build OpenMPI, PETSc and OpenVSP, and it uses "latest" and "old" package versions that don't match the rest of our packages. It would be much cleaner if we could run the OAS CI jobs on our docker containers where we have working environments with all the dependencies OAS needs and with stable and latests versions of things that match our other packages.
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable