-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect surface moment derivatives and added a moment output to the component #449
Conversation
…s related derivatives wrt reference area, chords, and panel width. Add output for moment with derivatives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sabakhshi! More comments are always appreciated, particularly in complex derivative routines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! I know you're working on it but I'm writing down as a note:
Test setup should be updated to be physically valid and to avoid false positive, which the current test does.
… derivativesas they have now been resolved. Don't want to confuse people in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more very minor comment. Could you also update the patch version for now so that we can track which versions have this fix while we wait on the numpy and openmdao update in #450?
Purpose
Adds moment as a directly output from OAS in addition to CM. Fixes bugs related to derivative computation for CM. Adds significant commentary to the derivative code to explain what is going on. Cleans up code.
Expected time until merged
1 week
Type of change
Testing
Some of the derivative updates need to be checked.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable