Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for The Diagram Styles #31

Merged
merged 11 commits into from
Aug 31, 2020
Merged

Cleanup for The Diagram Styles #31

merged 11 commits into from
Aug 31, 2020

Conversation

JustinSGray
Copy link
Contributor

Purpose

It was silly that all the xdsm scripts had the same hand-coded constants related to the diagram styles. I moved the constants into the XDSM.py file and changed all the examples to use the constants instead.

Type of change

New feature (non-breaking change which adds functionality)

Testing

I updated all the tests to use the new constants.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@JustinSGray JustinSGray requested a review from a team as a code owner August 31, 2020 18:11
@ewu63
Copy link
Collaborator

ewu63 commented Aug 31, 2020

Just to confirm, these constants are the ones used to map to the specific component styles right? I.e. these lines? So the names are not arbitrary since they must match the tikz style exactly, and all you did was to put these into the XDSM.py file so that they can be imported.

@JustinSGray
Copy link
Contributor Author

You understand correctly! The names must match the tikz styles exactly... so now they are just importable

@ewu63 ewu63 merged commit dc86e37 into mdolab:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants