Add a few french banks #237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 92.36% 92.69% +0.32%
==========================================
Files 22 22
Lines 1218 1218
Branches 95 95
==========================================
+ Hits 1125 1129 +4
+ Misses 75 72 -3
+ Partials 18 17 -1 ☔ View full report in Codecov by Sentry. |
| }, | ||
| { | ||
| "country_code": "FR", | ||
| "bic": "CMCIFRPP", |
There was a problem hiding this comment.
Are you sure about this BIC/SWIFT code? It looks like the CIC one
There was a problem hiding this comment.
| "bic": "CMCIFRPP", | |
| "bic": "ELFAFRP1XXX", |
| }, | ||
| { | ||
| "country_code": "FR", | ||
| "bic": "CMCIFRPP", |
There was a problem hiding this comment.
Are you sure about this BIC/SWIFT code? It looks like the CIC one
There was a problem hiding this comment.
| "bic": "CMCIFRPP", | |
| "bic": "FACFFRPP", |
| }, | ||
| { | ||
| "country_code": "FR", | ||
| "bic": "CMCIFRPP", |
There was a problem hiding this comment.
| "bic": "CMCIFRPP", | |
| "bic": "CRNPFRP1XXX", |
| "name": "HSBC FACTORING FRANCE", | ||
| "short_name": "HSBC FACTORING FRANCE", |
There was a problem hiding this comment.
| "name": "HSBC FACTORING FRANCE", | |
| "short_name": "HSBC FACTORING FRANCE", | |
| "name": "LA BANQUE POSTALE LEASING ET FACTORING", | |
| "short_name": "LA BANQUE POSTALE", |
| "bic": "AGRIFRP1EFG", | ||
| "bank_code": "16850", | ||
| "name": "CREDIT AGRICOLE SA (LEASING AND FACTORING)", | ||
| "short_name": "CREDIT AGRICOLE SA (LEASING AND FACTORING)", |
There was a problem hiding this comment.
| "short_name": "CREDIT AGRICOLE SA (LEASING AND FACTORING)", | |
| "short_name": "CREDIT AGRICOLE", |
| { | ||
| "country_code": "FR", | ||
| "bic": "CMCIFRPP", | ||
| "bank_code": "11978", |
| { | ||
| "country_code": "FR", | ||
| "bic": "CMCIFRPP", | ||
| "bank_code": "13580", |
| { | ||
| "country_code": "FR", | ||
| "bic": "CMCIFRPP", | ||
| "bank_code": "13888", |
| { | ||
| "country_code": "FR", | ||
| "bic": "CMCIFRPP", | ||
| "bank_code": "16478", |
| { | ||
| "country_code": "FR", | ||
| "bic": "AGRIFRP1EFG", | ||
| "bank_code": "16850", |
| { | ||
| "country_code": "FR", | ||
| "bic": "NTSBFRM1", | ||
| "bank_code": "20433", |
| { | ||
| "country_code": "FR", | ||
| "bic": "MPAYFRP1", | ||
| "bank_code": "21933", |
| { | ||
| "country_code": "FR", | ||
| "bic": "BUNQFRP2", | ||
| "bank_code": "27633", |
| { | ||
| "country_code": "FR", | ||
| "bic": "FNOMFRP2", | ||
| "bank_code": "30833", |
| "bic": "FNOMFRP2", | ||
| "bank_code": "30833", | ||
| "name": "FINOM PAYMENTS B.V.", | ||
| "short_name": "FINOM PAYMENTS B.V.", |
There was a problem hiding this comment.
| "short_name": "FINOM PAYMENTS B.V.", | |
| "short_name": "FINOM", |
There was a problem hiding this comment.
@AntoineDefacto thanks a lot for taking the time to add all this new bank codes.
I validated them all and it seems that there is a couple copy/paste issues, would you be willing to update your PR so that we can merge it?
Best,
Rémy
| "bic": "CMCIFRPP", | ||
| "bank_code": "13888", | ||
| "name": "HSBC FACTORING FRANCE", | ||
| "short_name": "HSBC FACTORING FRANCE", |
There was a problem hiding this comment.
| "short_name": "HSBC FACTORING FRANCE", | |
| "short_name": "HSBC", |
| "bic": "BUNQFRP2", | ||
| "bank_code": "27633", | ||
| "name": "BUNQ B.V.", | ||
| "short_name": "BUNQ B.V.", |
There was a problem hiding this comment.
| "short_name": "BUNQ B.V.", | |
| "short_name": "BUNQ", |
|
Superseded by #238 |
Add a few french banks we discovered at Defacto (https://getdefacto.com).
We discovered the bank codes from IBAN shared by our users.
The source for bank names is https://bank-codes.fr/swift-code/france/facffrpp/ which is maintained by Wise.