refactor: use relative paths to import from "src" #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: delete "remappings" config option from Foundry config style: format "foundry.toml" with Taplo
PaulRBerg
changed the title
|
Was there a specific issue you had from the current |
|
Yes, I couldn't use the library because of the |
|
Cool, happy to change if it was causing issues. Thanks! |
mds1
approved these changes
Feb 3, 2023
|
@PaulRBerg Thanks! |
|
Awesome thanks @mds1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes foundry-rs/foundry#3440 for users who need this library.
There really is just one place where
src/is used as an import path, so I think that switching it to../srcand deleting the remappings is well worth it given Foundry's limited capability to handle nested remappings.Changelog