Fixe a use-case when scope path is not set yet #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauth_client/lambda_helper.py
Outdated
| @@ -20,4 +20,4 @@ def _get_private_key(): | |||
| except ModuleNotFoundError: | |||
| pass | |||
|
|
|||
| return private_key.replace(" ", "\n").replace("\nRSA\nPRIVATE\nKEY", " RSA PRIVATE KEY") | |||
| return private_key.replace("\\n", " ").replace(" ", "\n").replace("\nRSA\nPRIVATE\nKEY", " RSA PRIVATE KEY") | |||
There was a problem hiding this comment.
hmm, seems like the name of the file is rather deceptive if this code it affecting things other than Lambdas? @ykitamura-mdsol
There was a problem hiding this comment.
Yeah, good point. We used to use this only in Lambdas but not anymore.
Since renaming will break backward compatibility, I think it will require a major version upgrade.
Probably we should do it in a separate PR.
emejia-mdsol
force-pushed
the
fix/asgi-middleware-scope
branch
from
af2d50b to
d9bd6fc
Compare
|
This happens within the context of a server starting up, making it difficult to add unit tests to this PR as it is not part of the dependencies of this project. |
emejia-mdsol
force-pushed
the
fix/asgi-middleware-scope
branch
from
d9bd6fc to
2881f42
Compare
ejinotti-mdsol
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes an issue when the private key has
\ncharacters, for example, copying a private key from Medistrano and using the insomnia plugin to make it a one-liner.https://github.com/mdsol/mauth-insomnia-plugin/blob/master/doc/install_guide.md#converting-private-keys
Merging this PR will fix this deployment.
https://service.sumologic.com/ui/#/search/create?id=UpyuWYAE1CYLchXGppQNsgwnqeGRCPKzfr7m6jbN