Preparing for open-sourcing #14
Conversation
| @@ -2,6 +2,9 @@ | |||
| name = "mauth-core" | |||
| version = "0.4.1" | |||
| edition = "2021" | |||
| authors = ["Medidata Solutions <support@mdsol.com>"] | |||
| license = "MIT" | |||
| repository = "https://github.com/mdsol/mauth-core" | |||
There was a problem hiding this comment.
do we need anything else?
There was a problem hiding this comment.
I think this needs a number of other fields in order to publish to crates.io. See the list in the docs here. You should use the cargo publish --dry-run command locally to verify that everything is valid. See the section in my crate for an example.
Your dependency list is also not very good for a crate. All of your dependencies should have much looser constraints that reflect what the code actually requires; nothing should be =. As is, I believe you would be requiring any crate that integrated with yours to use the exact same versions of every dependency you have.
There was a problem hiding this comment.
the cargo publish --dry-run just complained about missing the description field but added some other fields also in 706ac9d
nothing should be
=.
The cargo book says this so I think it is good as-is...
Although it looks like a specific version of the time crate, it actually specifies a range of versions and allows SemVer compatible updates.
There was a problem hiding this comment.
Interesting, I was not aware of that regarding = in Cargo.toml. Looks good to me now then.
|
cc @glow-mdsol |
| @@ -2,6 +2,9 @@ | |||
| name = "mauth-core" | |||
| version = "0.4.1" | |||
| edition = "2021" | |||
| authors = ["Medidata Solutions <support@mdsol.com>"] | |||
| license = "MIT" | |||
| repository = "https://github.com/mdsol/mauth-core" | |||
There was a problem hiding this comment.
Interesting, I was not aware of that regarding = in Cargo.toml. Looks good to me now then.
Updated docs to get ready for open-sourcing
@mdsol/architecture-enablement