[Feat] Table params #645
Merged
[Feat] Table params #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why limit ourselves
|
Won't this result in a breaking change, now that both options will default to false? |
|
They default to true, actually. But if you want that to be enforced regardless of the underlying package, I'll put the default back aswell |
|
I would rather have the true explicitly passed. Otherwise this looks good to me. |
|
I dis this commit on the GitHub mobile app. If you don't wanna test it rn, I will do it tomorrow |
|
This seems right to me, please check and if it works I will merge. |
|
It works. |
|
🎉 This PR is included in version 3.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TablePluginnow takes in the sameOptionsasgfmTableand passes them on