Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to TS Plugin #371

Merged
merged 48 commits into from
Mar 1, 2024
Merged

Migrate to TS Plugin #371

merged 48 commits into from
Mar 1, 2024

Conversation

johnsoncodehk
Copy link
Contributor

@johnsoncodehk johnsoncodehk commented Dec 14, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Ref: vuejs/language-tools#3789

Migrate to TS Plugin for native tsserver performance.

This also uses a hack (See microsoft/vscode/issues/200511) to enable the typescript extension's status bar features (ts version, server state), editor commands (restart ts server, goto config file), find file reference feature for mdx files.

(I may not be able to respond quickly, so if any modifications are needed I recommend bypassing me and pushing commit directly. 🙏)

johnsoncodehk and others added 26 commits November 17, 2023 05:46
The .jsx suffix is used everywhere else.
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: 42ea751

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@mdx-js/language-server Minor
vscode-mdx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Dec 14, 2023

This comment has been minimized.

@johnsoncodehk johnsoncodehk mentioned this pull request Feb 8, 2024
42 tasks
@johnsoncodehk johnsoncodehk marked this pull request as ready for review March 1, 2024 17:51
@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 1, 2024
@remcohaszing remcohaszing merged commit 7539a98 into mdx-js:main Mar 1, 2024
4 checks passed
@remcohaszing remcohaszing deleted the ts-plugin branch March 1, 2024 19:42

This comment has been minimized.

@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🏁 area/perf This affects performance 🧒 semver/minor This is backwards-compatible change 💪 phase/solved Post is done labels Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 area/perf This affects performance 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

2 participants