-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to TS Plugin #371
Merged
Merged
Migrate to TS Plugin #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .jsx suffix is used everywhere else.
Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
Co-authored-by: Remco Haszing <remcohaszing@gmail.com> Signed-off-by: Johnson Chu <johnsoncodehk@gmail.com>
🦋 Changeset detectedLatest commit: 42ea751 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment has been minimized.
This comment has been minimized.
42 tasks
github-actions
bot
added
🤞 phase/open
Post is being triaged manually
and removed
👋 phase/new
Post is being triaged automatically
labels
Mar 1, 2024
This comment has been minimized.
This comment has been minimized.
remcohaszing
added
🦋 type/enhancement
This is great to have
🏁 area/perf
This affects performance
🧒 semver/minor
This is backwards-compatible change
💪 phase/solved
Post is done
labels
Mar 1, 2024
Merged
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏁 area/perf
This affects performance
💪 phase/solved
Post is done
🧒 semver/minor
This is backwards-compatible change
🦋 type/enhancement
This is great to have
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Ref: vuejs/language-tools#3789
Migrate to TS Plugin for native tsserver performance.
This also uses a hack (See microsoft/vscode/issues/200511) to enable the typescript extension's status bar features (ts version, server state), editor commands (restart ts server, goto config file), find file reference feature for mdx files.
(I may not be able to respond quickly, so if any modifications are needed I recommend bypassing me and pushing commit directly. 🙏)