-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce churn #1015
Comments
npm 7 may help, v7 adds support for workspaces which was previously one of the main draws for yarn.
takes around 59-68 seconds.
takes between 42 to 48 seconds. I expect the results would be even more pronounced on Github Actions.
Cache time may be mostly unavoidable but, tying into:
Allowing version ranges could allow the version resolver some more flexibility in de-duplicating.
I'd push back on this a bit, while uncommon, there can be some MacOS specific issues.
Which tests across all OSes, but only tests previous Node versions in a specific OS. |
Do you have some specific tools in mind, which don't spark joy anymore?
👍 |
Renovate has some pretty powerful configuration options. Another which lines up with possibly loosening:
would be |
This updates the dependencies and dev-dependencies in `packages/`. Unfortunately, either updating to webpack 5 or updating to react 17 crash the webpack loader with a react error, with an [invalid hook call warning](https://reactjs.org/warnings/invalid-hook-call-warning.html) for `useMDXComponents`: <https://github.com/mdx-js/mdx/blob/dafdf6d70affa5dba0b3b7070f7a310b70bbf775/packages/react/src/context.js#L15> Which might have to do with the magic of shortcodes (#1385), or something else, I have no clue. Furthermore, this loosens package dependencies instead of locking them, which relates to GH-865, GH-1015, and GH-1267. It was a long and divided discussion before and the reason for changing now is: While the package currently doesn’t break easily (it was mentioned that unlocking packages might cause that), we are currently *locked* on security vulnerabilities. We’re not getting any patches, and MDX isn’t released that frequently or maintained that actively, so MDX users are stuck. If folks want to lock: npm and yarn have package locks. Closes GH-1267. Closes GH-1375.
This updates the dependencies and dev-dependencies in `packages/`. Unfortunately, either updating to webpack 5 or updating to react 17 crash the webpack loader with a react error, with an [invalid hook call warning](https://reactjs.org/warnings/invalid-hook-call-warning.html) for `useMDXComponents`: <https://github.com/mdx-js/mdx/blob/dafdf6d70affa5dba0b3b7070f7a310b70bbf775/packages/react/src/context.js#L15> Which might have to do with the magic of shortcodes (#1385), or something else, I have no clue. Furthermore, this loosens package dependencies instead of locking them, which relates to GH-865, GH-1015, and GH-1267. It was a long and divided discussion before and the reason for changing now is: While the package currently doesn’t break easily (it was mentioned that unlocking packages might cause that), we are currently *locked* on security vulnerabilities. We’re not getting any patches, and MDX isn’t released that frequently or maintained that actively, so MDX users are stuck. If folks want to lock: npm and yarn have package locks. Closes GH-1267. Closes GH-1375.
This updates the dependencies and dev-dependencies in `packages/`. Unfortunately, either updating to webpack 5 or updating to react 17 crash the webpack loader with a react error, with an [invalid hook call warning](https://reactjs.org/warnings/invalid-hook-call-warning.html) for `useMDXComponents`: <https://github.com/mdx-js/mdx/blob/dafdf6d70affa5dba0b3b7070f7a310b70bbf775/packages/react/src/context.js#L15> Which might have to do with the magic of shortcodes (#1385), or something else, I have no clue. Furthermore, this loosens package dependencies instead of locking them, which relates to GH-865, GH-1015, and GH-1267. It was a long and divided discussion before and the reason for changing now is: While the package currently doesn’t break easily (it was mentioned that unlocking packages might cause that), we are currently *locked* on security vulnerabilities. We’re not getting any patches, and MDX isn’t released that frequently or maintained that actively, so MDX users are stuck. If folks want to lock: npm and yarn have package locks. Closes GH-1267. Closes GH-1375. Closes GH-1392.
Create React App is the most looked at resource by users here on GitHub. But it’s suggesting an old, unmaintained, and buggy way to use MDX. This instead updates the guide to use our maintained projects, without having to eject from CRA. As CRA itself is an ever-changing “init” tool, which can support MDX by following a couple steps, I don’t think it’s wise to have an example in the project: we want folks to do `npx create-react-app ...`, not clone our custom example. Not having CRA checked in also makes for a faster `yarn install`. Perhaps developing our own [CRA template](https://create-react-app.dev/docs/custom-templates) might be nice for the future, but for now I’ve kept it at an up to date and working guide. Related to GH-1015. Related to GH-1388. Closes GH-365. Closes GH-589.
Create React App is the most looked at resource by users here on GitHub. But it’s suggesting an old, unmaintained, and buggy way to use MDX. This instead updates the guide to use our maintained projects, without having to eject from CRA. As CRA itself is an ever-changing “init” tool, which can support MDX by following a couple steps, I don’t think it’s wise to have an example in the project: we want folks to do `npx create-react-app ...`, not clone our custom example. Not having CRA checked in also makes for a faster `yarn install`. Perhaps developing our own [CRA template](https://create-react-app.dev/docs/custom-templates) might be nice for the future, but for now I’ve kept it at an up to date and working guide. Related to GH-1015. Related to GH-1388. Closes GH-365. Closes GH-589.
Create React App is the most looked at resource by users here on GitHub. But it’s suggesting an old, unmaintained, and buggy way to use MDX. This instead updates the guide to use our maintained projects, without having to eject from CRA. As CRA itself is an ever-changing “init” tool, which can support MDX by following a couple steps, I don’t think it’s wise to have an example in the project: we want folks to do `npx create-react-app ...`, not clone our custom example. Not having CRA checked in also makes for a faster `yarn install`. Perhaps developing our own [CRA template](https://create-react-app.dev/docs/custom-templates) might be nice for the future, but for now I’ve kept it at an up to date and working guide. Related to GH-1015. Related to GH-1388. Closes GH-365. Closes GH-589. Closes GH-1422. Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com>
* yarn is having problems hoisting dependencies * workspaces are built into npm now * GHA + npm have some fancy caching mechanisms Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com> Related-to: GH-1015.
This tests on all OSs (adding macOs) on latest Node & removes the Windows test on older nodes (latest Node is still tested). Related-to: #1015.
solved, actions are much faster, the repo is installable, etc. |
Hi folks! 👋
I just came back to this repo after a while, going through issues, PRs, dependency updates, etc, and this may just be me but to me it feels like there’s a bit much churn to maintain this repo:
Also seems that GH runs up to ± 6 builds at the same time, so in total it takes 15m-20m to check everything
package.json
, which I think makes sense for the MDX library, but it creates noise for dev-dependencies, examples, and the site: I find the current list of open PRs and list of commits pretty unreadableWhile tooling is great (hey, I spend all my time building tools), and maybe I’m just horribly out of touch with what modern development is supposed to look like, I think it would help maintainers and contributors if we could make the repo simpler and builds faster and less fragile! A couple of ideas:
remark-*
stuff to the @remarkjs orgThe text was updated successfully, but these errors were encountered: