-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loader renderer option #725
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://mdx-git-fork-axdg-loader-prepend.mdx.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This looks good to me, just a couple nits.
Also, I'm going to think a bit on whether there's a clearer name than prepend
for a bit.
pragma
renderer
- ... 🤔
cc/ @wooorm (you're always good at naming things 😄)
@johno, I've made the suggested changes. I agree that |
P.S. I don't like From wikipedia:
The pragma in this case would be the directive |
Yeah, I think I'm liking |
Updated that last commit and the docs (feel free to squash anyway) - |
Thanks! |
@johno ah sorry I missed this ping! Render is good! |
This fixes #711
prepend
to the Webpack loader'soptions
./* @jsx mdx */
- this is not needed since mdx itself adds this during compilation.All changes are completely backwards compatible... this would just allow for other frameworks to be used with the loader.