Update docker repo, and mirage-net-psock dependency #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mor1
requested changes
Nov 18, 2019
mor1
requested changes
Dec 27, 2019
Dockerfile
Outdated
| FROM ocaml/opam-dev:alpine-3.6_ocaml-4.04.2 as BUILDER | ||
| FROM ocaml/opam2:alpine-3.7-ocaml-4.04 as BUILDER | ||
|
|
||
| ENV OCAMLYES=true |
Dockerfile-relay
Outdated
|
|
||
| WORKDIR /core-network | ||
| ADD core-network.export core-network.export | ||
|
|
||
| ENV OCAMLYES=true |
|
Seems to have build failures...? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name for opam docker image has changed and mirage-net-psock needs to be pinned against an old version of the repo to allow it to build. This PR fixes both of those issues.
(additional
-ys to allow docker building)