Merge pull request #31 from meanbee/30-improve-check-for-file-move-su…

…ccess Fixes #30: Check directory is writable before moving downloaded file.
meanbee · Mar 16, 2016 · e4cb77e · e4cb77e
2 parents 6a3c905 + c7c41ef
commit e4cb77e
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/Meanbee/Magedbm/Command/GetCommand.php b/src/Meanbee/Magedbm/Command/GetCommand.php
@@ -218,8 +218,16 @@ protected function backupMove($file)
     {
         $filename = $this->getFilePath($file);
         $newFilename = getcwd() . '/' . $file;
-        if (rename($filename, $newFilename)) {
-            $this->getOutput()->writeln("<info>Downloaded to $newFilename.</info>");
+
+        if (!is_writable(getcwd())) {
+            $this->getOutput()->writeln("<info>Unable to write to current working directory. Check $filename</info>");
+            return;
+        }
+
+        $result = rename($filename, $newFilename);
+
+        if ($result && file_exists($newFilename)) {
+            $this->getOutput()->writeln("<info>Downloaded to $newFilename</info>");
         } else {
             $this->getOutput()->writeln("<error>Failed to move backup to current working directory. Check $filename</error>");
         }