Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Running an AngularJS App in Production #1294

Closed
2 tasks done
simison opened this issue Apr 4, 2016 · 4 comments
Closed
2 tasks done

Running an AngularJS App in Production #1294

simison opened this issue Apr 4, 2016 · 4 comments
Assignees
@lirantal @codydaig
Labels
enhance:feature need:pr_required
Milestone
0.5.0

Comments

@simison
Copy link
Member

simison commented Apr 4, 2016 •
edited
Loading

Two things from https://docs.angularjs.org/guide/production

Todo:

  • Disabling Debug Data
  • Strict DI Mode

Thoughts how to implement these?
@codydaig
Copy link
Member

codydaig commented Apr 4, 2016

I think to disable debug data, we have to somehow load config into the client side. This is something that has come up a lot, but has not been implemented.

However, I think we can do the strict DI mode with the index.html template in swig.

@pgrodrigues
Copy link
Contributor

I opened a similar issue a few months ago, however I implemented this in some yeoman angular app scaffolding, not in meanjs :(

I agree with @codydaig, ng-strict-di can be set using swig.

@lirantal
Copy link
Member

lirantal commented Apr 7, 2016

Will you guys work on a PR for this, sounds like a good idea.

@lirantal lirantal added this to the 0.5.0 milestone Apr 7, 2016
@codydaig codydaig self-assigned this Apr 9, 2016
@pgrodrigues pgrodrigues mentioned this issue Apr 11, 2016
Closed
simison added a commit to simison/mean that referenced this issue Aug 28, 2016
@simison
feat(core): disable Angular debug data in production
d972980 
Disable Angular debug data in production for a significant performance
boost.

Passes environment variable from template to app config and from there
to
Angular bootstrap config.

https://docs.angularjs.org/guide/production#disabling-debug-data

See meanjs#1294
@simison simison mentioned this issue Aug 28, 2016
Merged
lirantal pushed a commit that referenced this issue Aug 28, 2016
@simison @lirantal
feat(angular): disable Angular debug data in production (#1457)
07a860f 
Disable Angular debug data in production for a significant performance
boost.

Passes environment variable from template to app config and from there
to
Angular bootstrap config.

https://docs.angularjs.org/guide/production#disabling-debug-data

See #1294
@lirantal
Copy link
Member

lirantal commented Aug 28, 2016 •
edited
Loading

@simison you handled in the recent PR #1457 the debug data. What about the ng-strict-di? how do we handle that?

EDIT: nm, following the thread of issues I see we already covered it too.

@lirantal lirantal self-assigned this Aug 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lirantal lirantal

@codydaig codydaig

Labels
enhance:feature need:pr_required
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
4 participants
@simison @lirantal @codydaig @pgrodrigues