fix(dependencies): updating package dependencies to keep up to date versions #1254
Conversation
|
I'm curious about this part of the build: https://travis-ci.org/meanjs/mean/jobs/114363151#L1986 How is it that Protractor is getting installed as a project dependency? Is that Travis CI thing? |
|
Never mind, I see that it's being installed from our |
|
Is there anything stopping us from stopping our support of Node 0.12.x? I upgraded to Node 4 last week, and haven't run into any issues. Our builds have been consistently passing the Node 4 checks as well. |
| @@ -28,7 +28,7 @@ | |||
| "chalk": "~1.1.1", | |||
| "compression": "~1.6.1", | |||
| "connect-flash": "~0.1.1", | |||
| "connect-mongo": "~0.8.2", | |||
| "connect-mongo": "~1.1.0", | |||
There was a problem hiding this comment.
I'd rather drop Node 0.12 support, because this is not the only package we haven't updated and Node 0.12 isn't often the reported version our users use.
|
I think dropping support for Node 0.12 is a bigger decision than this PR. @codydaig what do you think? |
|
Node 0.12 enters maintenance mode on April 2016 and End of Life on April 2017: https://github.com/nodejs/LTS/ And also: |
|
We don't need to wait for 0.12 to enter maintenance for us to drop, we can do it if our framework will be better and our users don't need it. Most issues request Node 5 support, not Node 0.12 support.. |
|
@ilanbiala alright, I'll start by updating this PR for it. |
|
👍 |
lirantal
force-pushed
the
bugfix/updating_packages
branch
from
1aca4ea to
44fd1ea
Compare
|
@mleanos could you advise what's the issue with the protractor e2e tests failing? do we need to take back down on one of the packages I upgraded in this PR for protractor to work? |
|
Coverage remained the same at 70.615% when pulling c55133109f13c3342ecf39a11d5baa9aea300ee7 on lirantal:bugfix/updating_packages into 47b228c on meanjs:master. |
|
Ok nm. @ilanbiala looks like we're good here and build passes. |
|
Nope, LGTM, but the rebase might change some stuff, so I'll review one more time before we merge just to be sure. |
lirantal
force-pushed
the
bugfix/updating_packages
branch
2 times, most recently
from
23de1a9 to
2ed6c40
Compare
|
@ilanbiala you're welcome to review once more. |
|
Coverage remained the same at 70.615% when pulling 23de1a94e39610315b0c0b985dc236c9d701f94f on lirantal:bugfix/updating_packages into bc3d536 on meanjs:master. |
|
Coverage remained the same at 70.615% when pulling 2ed6c40efce609dc7f05c974995e9b0e82320aaa on lirantal:bugfix/updating_packages into bc3d536 on meanjs:master. |
|
LGTM |
|
There are newer versions of some of these packages: Also, the commit part about /es5 and gulp-wiredep is extraneous now |
|
Well I didn't include those in my update to begin with but I'll take a look at the latest versions for them. |
…ersions * updating to newer packages * updating travis to remove node v0.12
lirantal
force-pushed
the
bugfix/updating_packages
branch
from
2ed6c40 to
7da7419
Compare
|
@lirantal LGTM. |
|
|
fix(dependencies): updating package dependencies to keep up to date versions
No description provided.