This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
fix(client): lint issues for confirm() messages not referencing the window object
#1259
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we use Angular's |
lirantal
force-pushed
the
bugfix/lint-confirm-functions
branch
from
0c552b3 to
dcdbdb0
Compare
|
@mleanos you're right, I updated accordingly. |
|
LGTM |
1 similar comment
|
LGTM |
|
@lirantal Thank you. LGTM. |
|
I just double checked, and the ESLint warnings go away after the changes here are implemented. |
lirantal
force-pushed
the
bugfix/lint-confirm-functions
branch
from
6dd64ea to
80226a2
Compare
lirantal
added a commit
that referenced
this pull request
Mar 17, 2016
fix(client): lint issues for confirm() messages not referencing the `window` object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.