This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Enhancement: Deprecating Grunt in favor of Gulp and NPM commands #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulp being the mainstream vs the deprecation of grunt. Also added gulp as a task runner for freely executing tasks through Lifecycle scripts included in meanjs:
start
gulp
test
gulp test
postinstall
bower install --allow-root && bower prune --allow-root
available via `npm run-script`:
update
npm update && npm prune && bower install --allow-root && bower prune --allow-root
start:prod
gulp prod
start:debug
gulp debug
gulp
gulp
lint
gulp lint
test:server
gulp test:server
test:client
gulp test:client
test:e2e
gulp test:e2e
test:watch
gulp test:server:watch
test:watch:onlyChanged
gulp test:server:watch --onlyChanged
generate-ssl-certs
scripts/generate-ssl-certs.sh commands
| @@ -91,12 +95,13 @@ That's it! Your application should be running. To proceed with your development, | |||
| If you encounter any problems, try the Troubleshooting section. | |||
|
|
|||
| * explore `config/env/development.js` for development environment configuration options | |||
| * it is possible to | |||
There was a problem hiding this comment.
Oh, I just forgot to actually end that text... I wanted to refer to @mleanos 's comment about doing 'npm run gulp ' - checkout the updated PR.
|
@lirantal Overall looks good, just one line that seems out of place to me. |
| ``` | ||
| It will try to seed the users 'user' and 'admin'. If one of the user already exists, it will display an error message on the console. Just grab the passwords from the console. | ||
|
|
||
| In Production: | ||
| ```bash | ||
| MONGO_SEED=true grunt prod | ||
| MONGO_SEED=true npm start:prod |
There was a problem hiding this comment.
This may be out of the scope of this PR, but I feel that the MONGO_SEED option here is a bit confusing. I think we could just move the seeding option to it's own section.
|
LGTM (other than what Cody pointed out). Also, my comment isn't that much of a priority, and can be addressed in a separate PR if need be. |
|
LGTM |
1 similar comment
|
LGTM |
|
Thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(gulp): updating the README.md instructions with the changes to gulp being the mainstream vs the deprecation of grunt. Also added gulp as a task runner for freely executing tasks through running
npmcommandsFollow-up for #1296