This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Refactoring Tests for User model #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| should.not.exist(err); | ||
| done(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
nitpick, but inconsistent space? If we want more spacing (which may be the case with some of the tests), we should have above and below.
|
Looks good, just some minor nitpicks. |
…only during tests, so that we can re-use mongodb's _v versioning fields, and also cleaning up user tests on each test iteration
lirantal
force-pushed
the
feature/users_module_tests
branch
from
791284a to
346ebd6
Compare
|
Thanks @ilanbiala , missed your CR :) |
|
That looks awesome to me! |
|
Cool, thanks. |
|
LGTM |
lirantal
added a commit
that referenced
this pull request
Aug 5, 2015
Refactoring Tests for User model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-factoring the server model tests to create user model from schema only during tests, so that we can re-use mongodb's _v versioning fields, and also cleaning up user tests on each test iteration