-
-
Notifications
You must be signed in to change notification settings - Fork 989
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #28 from mebjas/viewfinderfix
Fix inconsistency between viewfinder qrbox and actual feed in canvas
- Loading branch information
Showing
7 changed files
with
411 additions
and
232 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
.DS_Store | ||
node_modules/ | ||
package-lock.json | ||
.vscode/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
### Version 1.0.7 | ||
+ Fixed the video size issue in [issues/21](https://github.com/mebjas/html5-qrcode/issues/21) | ||
+ Removed fixed height of viewfinder, now the height is based on the video stream. The width is honored if the input element has a default width. Otherwise default width is applied. | ||
+ If `config.qrbox` is greater than derived height, the config is ignored & no shading is applied. | ||
+ The sequence of steps have changed | ||
+ First we get the video feed from the selected camera | ||
+ Then we render video | ||
+ Then based on the height of the video we set the canvas and start scanning. | ||
+ For file scanning, if the container element has some height or width both are honored. | ||
Otherwise default width is applied and height is derived from the image. | ||
|
||
### Older versions | ||
Mostly covered in [readme](./README.md), changelog tracking started since `version 1.0.7` |
Oops, something went wrong.