Improved error message for "Missing skill or step out of reach" case …

…by adding job.id (VROOM-Project#946)
mebymyself · Jul 13, 2023 · caedda4 · caedda4
1 parent e6a92c0
commit caedda4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@
 - Update polylineencoder to v2.0.1 (#931)
 - Switch to C++20 (#851)
 - Improved error messages for file-related IO errors (#553)
+- Improved error message for "Missing skill or step out of reach" case by adding job.id (#946)
 
 ### Fixed
 

diff --git a/src/algorithms/heuristics/heuristics.cpp b/src/algorithms/heuristics/heuristics.cpp
@@ -923,8 +923,9 @@ template <class T> T initial_routes(const Input& input) {
       job_ranks.push_back(job_rank);
 
       if (!input.vehicle_ok_with_job(v, job_rank)) {
-        throw InputException("Missing skill or step out of reach for vehicle " +
-                             std::to_string(vehicle.id) + ".");
+        throw InputException("Missing skill or step out of reach for vehicle=" +
+                             std::to_string(vehicle.id) + ", job=" +)
+                             std::to_string(job.id) + ".";
       }
 
       assert(step.job_type.has_value());