Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .github/workflows/test.yml #187

Closed
moorepants opened this issue Feb 18, 2023 · 1 comment
Closed

Remove .github/workflows/test.yml #187

moorepants opened this issue Feb 18, 2023 · 1 comment

Comments

@moorepants
Copy link
Collaborator

We have tests.yml which covers a matrix of os, python, and ipopt versions. There is also test.yml that seems to cover one instance of that matrix and is redundant. I'm not sure why we have test.yml. I think it probably should be removed.

@brocksam
Copy link
Collaborator

The original reasons for this was that test.yml (with its single OS, Python version, and IPOPT version combination) is triggered on push and PR to all branches, while tests.yml (with the full matrix) is only triggered on PR to the master branch. The reason I did this in the first place no longer really feels valid: parallel jobs were limited to two at a time and the Windows jobs took ~15 mins, so if a test was failing because of a general mistake it could take a few hours to get that feedback via PR.

I think we can delete test.yml and change the on conditions in tests.yml to be just on: [push, pull_request].

moorepants added a commit that referenced this issue Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants