MAINT: minimize_ipopt: fix late binding bug when defining constraint Jacobians #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #194 (comment),
minimize_ipopt
fails on thescipy.optimize.minimize
example with three constraints. This is due to a late binding gotcha when the constraint Jacobians are defined in a loop. This fixes that bug and demonstrates that the example problem is solved successfully after the fix.Incidentally, this also fixes an unreported bug:
kwargs
was being passed toapprox_fprime
. butapprox_fprime
doesn't acceptkwargs
. Another instance of this bug is fixed in https://github.com/mechmotum/cyipopt/pull/200/files#r1198383113.