-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now picks up Windows Ipopt binary files that are adjacent to setup.py (restores regression) #220
Now picks up Windows Ipopt binary files that are adjacent to setup.py (restores regression) #220
Conversation
Getting this on windows:
|
If I use |
I don't understand why the windows builds in CI have been working without setting "IPOPTWINDIR=USECONDAFORGEIPOPT" before. Maybe |
Maybe it was working with conda forge ipopts that had the ipopt binary file (pkg-config) would pick it up, but now that binary is not in the windows conda forge builds, so it fails. |
Squash + merge is fine for this one. Lot's of noise trying to get CI to run. |
At some point we disabled the appveyor windows CI run that would download an official Ipopt windows release and test building against that. In our documentation it implies that you can take the contents of that Ipopt zip file and place them adjacent to the setup.py file and they'd get picked up.
https://cyipopt.readthedocs.io/en/stable/install.html#from-source-on-windows says: "After Ipopt is extracted, the bin, lib and include folders should be in the root cyipopt directory, i.e. adjacent to the setup.py file." but it seems like we removed the support for this and it isn't present here:
https://github.com/mechmotum/cyipopt/blob/master/setup.py#L187
This adds back the functionality as well as a Github action to test that it works.