Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now picks up Windows Ipopt binary files that are adjacent to setup.py (restores regression) #220

Merged
merged 19 commits into from
Sep 16, 2023

Conversation

moorepants
Copy link
Collaborator

@moorepants moorepants commented Sep 15, 2023

At some point we disabled the appveyor windows CI run that would download an official Ipopt windows release and test building against that. In our documentation it implies that you can take the contents of that Ipopt zip file and place them adjacent to the setup.py file and they'd get picked up.

https://cyipopt.readthedocs.io/en/stable/install.html#from-source-on-windows says: "After Ipopt is extracted, the bin, lib and include folders should be in the root cyipopt directory, i.e. adjacent to the setup.py file." but it seems like we removed the support for this and it isn't present here:

https://github.com/mechmotum/cyipopt/blob/master/setup.py#L187

This adds back the functionality as well as a Github action to test that it works.

@moorepants moorepants changed the title Adds a Github action to build against the Ipopt Windows binaries. Now picks up Windows Ipopt binary files that are adjacent to setup.py (restores regression) Sep 15, 2023
@moorepants
Copy link
Collaborator Author

Getting this on windows:

  cyipopt/cython\ipopt_wrapper.c(760): fatal error C1083: Cannot open include file: 'IpoptConfig.h': No such file or directory

@moorepants
Copy link
Collaborator Author

If I use "cython<3" in the mamba install command on windows and put it in quotes bash seems to pick up the < as a bash operator. Maybe a bug in bash on windows?

@moorepants
Copy link
Collaborator Author

I don't understand why the windows builds in CI have been working without setting "IPOPTWINDIR=USECONDAFORGEIPOPT" before. Maybe pkg-config on Windows works?

@moorepants moorepants requested a review from brocksam September 16, 2023 04:16
@moorepants
Copy link
Collaborator Author

I don't understand why the windows builds in CI have been working without setting "IPOPTWINDIR=USECONDAFORGEIPOPT" before. Maybe pkg-config on Windows works?

Maybe it was working with conda forge ipopts that had the ipopt binary file (pkg-config) would pick it up, but now that binary is not in the windows conda forge builds, so it fails.

@moorepants
Copy link
Collaborator Author

Squash + merge is fine for this one. Lot's of noise trying to get CI to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant