Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples/ and docs/requirements.txt to source distribution #242

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

musicinmybrain
Copy link
Contributor

#237 (comment)

This PR seems to be effective for python3 setup.py sdist but not for python3 -m build.

MANIFEST.in Outdated Show resolved Hide resolved
@moorepants
Copy link
Collaborator

This may be better:

include setup.py
include AUTHORS
include LICENSE
include CHANGELOG.rst
include README.rst
recursive-include cyipopt *.py *.pyx *.pxd
recursive-include ipopt *.py
recursive-include tests *.py
recursive-include docs Makefile *.bat *.rst *.py requirements.txt
recursive-include examples *.py
exclude cyipopt/tests/unit/test_scipy_ipopt_from_scipy.py
prune include*
prune lib*

@musicinmybrain
Copy link
Contributor Author

musicinmybrain commented Nov 27, 2023

You’re absolutely right that I was misusing recursive-include. Thanks.

Also, I typo’ed .txt.

I’ve force-pushed a new pair of commits that makes much more sense, and which appear to work correctly with both python3 setup.py sdist and python3 -m build.

@moorepants
Copy link
Collaborator

I'm good with this. Thanks!

@moorepants moorepants merged commit 325dbb6 into mechmotum:master Nov 27, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants