Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/cand cluster category #253

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Hotfix/cand cluster category #253

merged 6 commits into from
Jan 29, 2025

Conversation

nlouwen
Copy link
Collaborator

@nlouwen nlouwen commented Jan 28, 2025

Refactors setting and getting of record categories:

  • moves the 'category' attribute to the general BGCRecord class
  • Region and Cand_cluster category is set during parsing, based on child protoclusters
  • Any 'Categoryless' records will have category=None, a category should always be fetched using the get_category method

small misc fixes:

  • fixes broken absence_presence UI download
  • small updates to help message
  • extra DB save after distance calculation

CatarinaCarolina
CatarinaCarolina approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@CatarinaCarolina CatarinaCarolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.....I think....brain hurts 🙈

@nlouwen nlouwen merged commit 2eeaec9 into dev Jan 29, 2025
2 checks passed
@nlouwen nlouwen deleted the hotfix/cand-cluster-category branch February 12, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatarinaCarolina CatarinaCarolina CatarinaCarolina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlouwen @CatarinaCarolina