Bug fix: Make sure we calculate correctly the video player height #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -755,6 +755,11 @@ | |||
| parentWidth = t.container.parent().closest(':visible').width(), | |||
| newHeight = t.isVideo || !t.options.autosizeProgress ? parseInt(parentWidth * nativeHeight/nativeWidth, 10) : nativeHeight; | |||
|
|
|||
| // When we use percent, the newHeight can't be calculated so we get the container height | |||
| if(isNaN(newHeight)) { | |||
| t.container.parent().closest(':visible').height(); | |||
There was a problem hiding this comment.
Shouldn't you be assigning that value to newHeight?
There was a problem hiding this comment.
Oh god, a bad copy/paste...
The request is updated!
… calculate newHeight so we get the container height
johndyer
added a commit
that referenced
this pull request
Mar 27, 2014
Bug fix: Make sure we calculate correctly the video player height
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Bug fix: Make sure we calculate correctly the video player height
ale-grosselle
pushed a commit
to ale-grosselle/mediaelement
that referenced
this pull request
Nov 25, 2016
Bug fix: Make sure we calculate correctly the video player height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want the video player get the same size of its container we set defaultVideoWidth and defaultVideoHeight to 100%. In that case the calculation of newHeight is not correct, so we get the container height