Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved RTMP URL parsing #574

Merged
merged 7 commits into from
Sep 23, 2012
Merged

Improved RTMP URL parsing #574

merged 7 commits into from
Sep 23, 2012

Conversation

sapientpants
Copy link
Contributor

Hi John,

Thanks for all your work in putting mediaelement together, it's been a pleasure to work with.

One thing I do need though is to be able to parse RTMP URLs with mp4: as the separator between the streamer and the stream.

This pull request adds parsing of RTMP URLs with mp3:, mp4: and flv: separators and when none of these are present, it uses the previous behaviour.

Thanks again,

Marc

@sapientpants
Copy link
Contributor Author

Sorry for all the white space changes, I had a hard time trying to get a clean diff of the actual changes. I notice that when I clone the repo I end up with mixed line endings - maybe you know more about git than I, but I couldn't come up with the proper config to allow me to commit without changing all the whitespace. Any ideas?

* upstream/master:
  2.9.3 release
  updated version number
  removed use of $ and inArray
  allows use of "max-width:100%"
  Fixed bug on line 48, added type to source buttons
  Fixing parentheses syntax error in events demo
  Changed $ to mejs.$ to prevent conflicts with other libraries
  Changed $ to mejs.$ to prevent conflicts with other libraries
  Fix IE<=8 indexOf compatibility (cannot be used on an array)

Conflicts:
	build/mediaelement-and-player.js
	build/mediaelement.js
	build/mediaelementplayer.js
	src/js/me-namespace.js
	src/js/mep-player.js
@cgrube
Copy link

cgrube commented Sep 19, 2012

Hi,
I am testing these changes to verify support for mp3 and mp4 RTMP streaming using the fallback flash player. It looks like this does correct the issue where RTMP URLs were being parsed incorrectly when the source video is located in a subdir of the FMS application dir.

However, I am not able to get streaming of MP3 using RTMP to work in any case. Progressive download works fine with a tag like . . .

<audio id="player1" width="400" height="364" controls="controls" preload="none" src="http://pso71-ora2/video/28_Wheels_on_the_Bus.mp3" type="audio/mp3">

So this is progressive download from a IIS web server over port 80. I have an FMS application pointing to the same physical location on the server, yet the following audio tag fails to playback the mp3 . . .

<audio id="player1" width="400" height="364" controls="controls" preload="none" src="rtmp://pso71-ora2/video/_definst_/mp3:28_Wheels_on_the_Bus.mp3" type="audio/mp3">

In the case of the mediaelements flash player, the player loads and presents controls but pressing the play button results in nothing. The request never makes it to FMS.

I have a tried URLS both with and without the"mp3:" marker and neither seem to work. I also have a separate web application with a custom embedded flash player that can successfully playback the mp3 at the above URL so I am confident that FMS is can receive and respond to the RTMP request.

@Pansapien, you explicitly mention mp3 above. Does this mean you have been able to playback an mp3 stream over RTMP using your modified version of the media elements flash player? If so can you provide an example of the audio tag you are using? Anything special I need to as far as player options to get this to work?

Thanks, Chad.

johndyer added a commit that referenced this pull request Sep 23, 2012
Improved RTMP URL parsing
@johndyer johndyer merged commit 6f81842 into mediaelement:master Sep 23, 2012
phuongdh pushed a commit to avalonmediasystem/mediaelement that referenced this pull request Oct 18, 2013
rexblack pushed a commit to rexblack/mediaelement that referenced this pull request May 22, 2014
rexblack pushed a commit to rexblack/mediaelement that referenced this pull request May 22, 2014
marmite22 pushed a commit to elucidat/mediaelement that referenced this pull request Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants