Adding YoutubeShort to documentation & fixing some type hints

medialab · Feb 29, 2024 · 1f273f2 · 1f273f2
1 parent eb152c4
commit 1f273f2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -1837,12 +1837,16 @@ from ural.youtube import (
   # You can also import the named tuples if you need them
   YoutubeVideo,
   YoutubeUser,
-  YoutubeChannel
+  YoutubeChannel,
+  YoutubeShort,
 )
 
 parse_youtube_url('https://www.youtube.com/watch?v=otRTOE9i51o')
 >>> YoutubeVideo(id='otRTOE9i51o')
 
+parse_youtube_url('https://www.youtube.com/shorts/GINlKobb41w')
+>>> YoutubeShort(id='GINlKobb41w')
+
 parse_youtube_url('https://lemonde.fr')
 >>> None
 

diff --git a/ural/youtube.py b/ural/youtube.py
@@ -277,7 +277,7 @@ def parse_youtube_url(url, fix_common_mistakes=True):
     _, _, path, query, fragment = parsed
 
     # youtu.be
-    if parsed.hostname.endswith("youtu.be"):
+    if parsed.hostname and parsed.hostname.endswith("youtu.be"):
 
         if path.count("/") > 0:
             v = pathsplit(path)[0]

diff --git a/ural/youtube.pyi b/ural/youtube.pyi
@@ -3,14 +3,15 @@ from ural.types import AnyUrlTarget
 
 class YoutubeVideo(NamedTuple):
     id: str
+    playlist: Optional[str]
 
 class YoutubeUser(NamedTuple):
-    id: str
+    id: Optional[str]
     name: str
 
 class YoutubeChannel(NamedTuple):
-    id: str
-    name: str
+    id: Optional[str]
+    name: Optional[str]
 
 class YoutubeShort(NamedTuple):
     id: str