Allowing two dashes properties on naming-convention #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strikkerpt
requested review from
ThaNarie,
ReneDrie,
leroykorterink and
hjeti
ThaNarie
reviewed
Oct 17, 2023
ThaNarie
approved these changes
Oct 20, 2023
leroykorterink
approved these changes
Nov 10, 2023
leroykorterink
force-pushed
the
feature/allow-css-variables-naming
branch
from
1afcb99
to
6ed2e95
Compare
leroykorterink
force-pushed
the
feature/allow-css-variables-naming
branch
from
6ed2e95
to
2b7889c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While animating components we interact a lot with css custom properties which start with [two dashes].(https://drafts.csswg.org/css-variables/).
Case Example:
gsap.to(element, {'--pseudo-opacity': 0});On the code above the following error will be dispatched:
ESLint: Object Literal Property name '--pseudo-opacity' must match one of the following formats: strictCamelCase(@typescript-eslint/naming-convention)This has led to a lot of suppressing in files that interact with css variables, in some cases the rule ends up disabled to the whole file, which prevent us from taking advantage of it.
This PR should allow us to filter properties that starts with -- and ignore them, avoiding suppressing the issue by not dispatching the error.