Enforce no-underscore-dangle in method names and class fields #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leroykorterink
added
enhancement
ThaNarie
reviewed
Mar 29, 2023
| @@ -10,6 +10,9 @@ | |||
| "eslint": "^8.28.0" | |||
| }, | |||
| "eslintConfig": { | |||
| "extends": "@mediamonks/eslint-config" | |||
| "extends": "@mediamonks/eslint-config", | |||
| "parserOptions": { | |||
There was a problem hiding this comment.
Do we also need this in the docs, or was this only for the #private stuff in the test code?
There was a problem hiding this comment.
Yes, it was needed to support new private field syntax, I don't think we should explain how to configure the language options for eslint because this can vary between projects. eslint has a full page about configuring the language options.
ThaNarie
approved these changes
Mar 29, 2023
leroykorterink
deleted the
#34-enforce-no-underscore-dangle-in-method-names-and-class-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34