Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using TransitionPresence outside the context of another TransitionPresence logs a warning #182

Closed
leroykorterink opened this issue Aug 24, 2023 · 0 comments
Closed

Using TransitionPresence outside the context of another TransitionPresence logs a warning #182

leroykorterink opened this issue Aug 24, 2023 · 0 comments
Assignees
@leroykorterink
Labels
bug Something isn't working

Comments

@leroykorterink
Copy link
Collaborator

See title, a warning is logged while it's fine to use a TransitionPresence outside the context of TransitionPresenceContext. We should directly use useContext(TransitionPresenceContext) in the TransitionPresence component to avoid the warning that is logged by useTransitionPresence.
@leroykorterink leroykorterink added the bug Something isn't working label Aug 24, 2023
@leroykorterink leroykorterink self-assigned this Aug 24, 2023
leroykorterink added a commit that referenced this issue Oct 9, 2023
@leroykorterink
#182 Only log missing context warning in public API
4fcc059
leroykorterink added a commit that referenced this issue Oct 9, 2023
@leroykorterink
Merge pull request #205 from mediamonks/feature/#182-using-transition…
aa815cf 
…presence-outside-the-context-of-another-transitionpresence-logs-a-warning

#182 Only log missing context warning in public API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leroykorterink leroykorterink

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leroykorterink