Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mandatory key for defer flow #112

Merged
merged 14 commits into from
Oct 6, 2023
Merged

Remove mandatory key for defer flow #112

merged 14 commits into from
Oct 6, 2023

Conversation

leroykorterink
Copy link
Collaborator

Changes:

  • crossFlow option is removed from TransitionPresence, the cross flow feature will be implemented via a new component.
  • Key on TransitionPresence child is not mandatory anymore. Children props and type are compared instead.
  • TransitionPresence removes previous children (waits a tick) before new children are added so that a new component instance created.

#92

@leroykorterink leroykorterink changed the title Remove mandatory key for defer flow [Draft] Remove mandatory key for defer flow Mar 23, 2023
@leroykorterink leroykorterink self-assigned this Mar 23, 2023
@leroykorterink leroykorterink added bug Something isn't working enhancement New feature or request labels Mar 23, 2023
@ThaNarie ThaNarie marked this pull request as draft March 23, 2023 10:10
@ThaNarie ThaNarie changed the title [Draft] Remove mandatory key for defer flow Remove mandatory key for defer flow Mar 23, 2023
@leroykorterink leroykorterink marked this pull request as ready for review April 24, 2023 17:23
@leroykorterink leroykorterink mentioned this pull request May 26, 2023
Closed
@leroykorterink leroykorterink force-pushed the bugfix/remove-mandatory-key-for-defer-flow branch from 2e0afd7 to de16c03 Compare October 6, 2023 11:31
@leroykorterink leroykorterink force-pushed the bugfix/remove-mandatory-key-for-defer-flow branch from 5b98f4b to dd0c01d Compare October 6, 2023 14:30
@jesse-mm jesse-mm self-requested a review October 6, 2023 14:50
@leroykorterink leroykorterink merged commit 63acdd7 into main Oct 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThaNarie ThaNarie ThaNarie left review comments

@jesse-mm jesse-mm jesse-mm approved these changes

Assignees

@leroykorterink leroykorterink

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leroykorterink @ThaNarie @jesse-mm