Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pipe for loom #619

Merged
merged 10 commits into from
Nov 29, 2024
Merged

feat: add pipe for loom #619

merged 10 commits into from
Nov 29, 2024

Conversation

tribhuwan-kumar
Copy link
Contributor

@tribhuwan-kumar tribhuwan-kumar commented Nov 1, 2024


name: pull request
about: description demo
ps: there is some video rendering issue in edge, fixing it

feat: #583
/claim #583


description

brief description of the changes in this pr.

related issue: #583

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

how to test

add a few steps to test the pr in the most time efficient way.

if relevant add screenshots or screen captures to prove that this PR works to save us time.

checklist

  • MOST IMPORTANT: this PR will require less than 30 min to review, merge, and release to production and not crash in the hand of thousands of users
  • i have read the CONTRIBUTING.md file
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works

additional notes

any other relevant information about the pr.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 4:25am

@louis030195
Copy link
Collaborator

louis030195 commented Nov 28, 2024

@tribhuwan-kumar whats the status of this PR again?

looks decent to merge already, can do audio later

also, would you want to sell this pipe? dm on discord @louis030195

we can make it easy to charge for it through the pipe store and you get the revenue

@tribhuwan-kumar
Copy link
Contributor Author

@tribhuwan-kumar whats the status of this PR again?

same as prior, just need to embed audio in video. i'll do it in free time cz there is some ffmpeg stuff to do!

looks decent to merge already, can do audio later

if you're okay with it then you can merge it!

also, would you want to sell this pipe? dm on discord @louis030195
we can make it easy to charge for it through the pipe store and you get the revenue

i don't get it. "sell this pipe" isn't that bounty is for creating this pipe?

@louis030195
Copy link
Collaborator

/approve

Copy link

algora-pbc bot commented Nov 29, 2024

@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@louis030195
Copy link
Collaborator

@tribhuwan-kumar we're setting up things so you can charge for pipes in the pipe store for for example people would have to pay $50 one time payment to use your pipe

@louis030195 louis030195 merged commit aaa45d1 into mediar-ai:main Nov 29, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants