feat: cosmos-sdk v0.45.3 upgrade ver #68
Conversation
| | SIGN_MODE_EIP_191 | 191 | SIGN_MODE_EIP_191 specifies the sign mode for EIP 191 signing on the Cosmos SDK. Ref: https://eips.ethereum.org/EIPS/eip-191 | ||
|
|
||
| Currently, SIGN_MODE_EIP_191 is registered as a SignMode enum variant, but is not implemented on the SDK by default. To enable EIP-191, you need to pass a custom `TxConfig` that has an implementation of `SignModeHandler` for EIP-191. The SDK may decide to fully support EIP-191 in the future. |
There was a problem hiding this comment.
I wonder where this SIGN_MODE_EIP_191 was found.
Because the documentation for cosmos-sdk version 0.45.3 doesn't include this. :)
There was a problem hiding this comment.
You're right. It is included in v0.45.5. It seems that it's tangled when checking out branches.
BTW, I'm preparing new PR for v0.45.4. Because the test of resetta is failed due to the version of go, which is required 1.17 or upper ver. It was fixed in v0.45.4.. After I test locally, I'll make a new PR.
Thanks for comments!
| @@ -78,8 +85,9 @@ func RandomizedGenState(simState *module.SimulationState) { | |||
| valAddrs[i] = valAddr | |||
|
|
|||
| maxCommission := sdk.NewDecWithPrec(int64(simulation.RandIntBetween(simState.Rand, 1, 100)), 2) | |||
| curCommissionRate := simulation.RandomDecAmount(simState.Rand, maxCommission.Sub(minComRate)).Add(minComRate) | |||
There was a problem hiding this comment.
I copied from v0.42.11-panacea branch (
)There was a problem hiding this comment.
Ah, that's right.
It is not important, but in the current test, if the value of min commission is not 0% (if it exceeds 1%), curCommissionRate may come out negative.
But as I mentioned above, it doesn't matter. :)
|
@gyuguen, @youngjoon-lee |
|
thank u. it’s good enough to use v0.45.4 |
The branch
v0.45.3-panaceais fromv0.45.3tag of cosmos-sdk.As done in #27, the minimum commission rate has been added to
x/stakingmodule.What I've done in this PR:
min_commission_rateto thex/stakingmoduleMustUpdateValidatorCommission()func since it is no longer needed.x/staking/legacy/v040/migrate.go, the oldstaking.pb.gofile is moved inside thelegacy/v040folder and it is used for migration. But, we need to migrate withmin_commission_rate, which is not included the oldstaking.pb.gofile, so I changed to use the generatedstaking.pb.gofile (v040staking.*)