Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix upgradeHander issue #353

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Jun 14, 2022

We ran into an error situation during the Testnet deployment.

Jun 10 03:09:17 testnet-sentry panacead[3707341]: panic: cannot delete latest saved version (12)
Jun 10 03:09:17 testnet-sentry panacead[3707341]: goroutine 1 [running]:
Jun 10 03:09:17 testnet-sentry panacead[3707341]: github.com/cosmos/cosmos-sdk/store/rootmulti.(*Store).pruneStores(0xc0001cc460)
Jun 10 03:09:17 testnet-sentry panacead[3707341]:         /home/ubuntu/go/pkg/mod/github.com/medibloc/cosmos-sdk@v0.42.11-panacea.1/store/rootmulti/store.go:388 +0x26e

This error occurs when the following code is excuted.
https://github.com/cosmos/cosmos-sdk/blob/v0.42.11/store/rootmulti/store.go#L380

CosmosHub has solved this related problem as follows.
https://github.com/cosmos/gaia/blob/v5.0.8/app/app.go#L428

We also modified it with reference to this.

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

app/app.go Outdated Show resolved Hide resolved
Co-authored-by: Youngjoon Lee <yjlee@medibloc.org>
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

danke

@gyuguen gyuguen merged commit 91a8646 into master Jun 14, 2022
@gyuguen gyuguen deleted the ft/na/v2.1.0-alpha2-fix-upgrade-handler branch June 14, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants