feat: [v2.0.x] upgrade cosmos-sdk to v0.45.4 #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngjoon-lee
changed the title
youngjoon-lee
commented
Oct 16, 2022
| // registerUpgradeHandlers registers upgrade handlers, and sets the store loader if necessary. | ||
| // This function must be called before sealing the BaseApp (i.e. by app.LoadLatestVersion()) | ||
| // because the storetypes loader cannot be set if BaseApp is already sealed. | ||
| func (app *App) registerUpgradeHandlers() error { |
There was a problem hiding this comment.
If we upgrade our mainnet to v2.0.5 with this upgrade handler, I think we must remove the upgrade handler in the master branch which is similar as this.
0xHansLee
reviewed
Oct 17, 2022
|
When upgrading to v0.45.9, configuration for grpc web is added to |
Yeah. I'll put a note in the gov proposal, that the grpc-web will be enabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to be merged to the
release/v2.0.xbranch, and be released with the tagv2.0.5after some additional PRs are merged as well.Just cherry-picked from 664d546
TODO: should be tested if the chain can be upgraded smoothly from 2.0.3 to 2.0.5 without hard forks