Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define skeleton proto files #515

Merged
merged 10 commits into from
Dec 6, 2022
Merged

feat: define skeleton proto files #515

merged 10 commits into from
Dec 6, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Dec 2, 2022

Closes #508

@gyuguen gyuguen added this to the v2.1.0-beta milestone Dec 2, 2022
@gyuguen gyuguen self-assigned this Dec 2, 2022
audtlr24
audtlr24 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

0xHansLee
0xHansLee reviewed Dec 5, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments :)

proto/panacea/datadeal/v2/consent.proto Outdated Show resolved Hide resolved
proto/panacea/datadeal/v2/deal.proto Outdated Show resolved Hide resolved
proto/panacea/datadeal/v2/tx.proto Outdated Show resolved Hide resolved
proto/panacea/oracle/v2/oracle.proto Outdated Show resolved Hide resolved
proto/panacea/oracle/v2/oracle.proto Outdated Show resolved Hide resolved
proto/panacea/oracle/v2/oracle.proto Outdated Show resolved Hide resolved
0xHansLee
0xHansLee approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

inchori
inchori approved these changes Dec 5, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

youngjoon-lee
youngjoon-lee approved these changes Dec 5, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
proto/panacea/datadeal/v2/consent.proto Outdated Show resolved Hide resolved
proto/panacea/datadeal/v2/deal.proto Outdated Show resolved Hide resolved
@gyuguen gyuguen merged commit 3887b20 into main Dec 6, 2022
@gyuguen gyuguen deleted the ft/508/skeleton_scalable branch December 6, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audtlr24 audtlr24 audtlr24 approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@gyuguen gyuguen

@audtlr24 audtlr24

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Define x/oracle and x/datadeal with proto files
5 participants
@gyuguen @youngjoon-lee @audtlr24 @0xHansLee @inchori