-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skeleton code for oracle module #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I left an one question.
} | ||
} | ||
|
||
func GetGenesisStateFromAppState(cdc codec.Codec, appState map[string]json.RawMessage) *GenesisState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question. Is this function neccessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the function used in the command to add genesis oracle. It's not important right now, but I think it will be used later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…racle # Conflicts: # .github/workflows/ci.yml # proto/panacea/datadeal/v2/deal.proto # proto/panacea/datadeal/v2/genesis.proto # proto/panacea/datadeal/v2/query.proto # proto/panacea/datadeal/v2/tx.proto # proto/panacea/oracle/v2/genesis.proto # proto/panacea/oracle/v2/oracle.proto # x/datadeal/types/deal.pb.go # x/datadeal/types/genesis.pb.go # x/datadeal/types/query.pb.go # x/datadeal/types/tx.pb.go # x/oracle/types/genesis.pb.go # x/oracle/types/oracle.pb.go
Add skeleton code for
x/oracle
.oracle.Params
toGenesisState