Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add create a deal and query a deal keeper function #525

Merged
merged 16 commits into from
Dec 8, 2022
Merged

feat: add create a deal and query a deal keeper function #525

merged 16 commits into from
Dec 8, 2022

Conversation

inchori
Copy link

@inchori inchori commented Dec 7, 2022

Closes #512

  • Add keeper functions of CreateDeal and query a Deal.
  • The CLI function of CreateDeal and Deal will be implemented in next branch based on this branch.

@inchori inchori added this to the v2.1.0-beta milestone Dec 7, 2022
@inchori inchori requested a review from cl9200 as a code owner December 7, 2022 02:46
@inchori inchori self-assigned this Dec 7, 2022
@inchori inchori changed the title feat: add create a Deal and query a Deal keeper function feat: add create a deal and query a deal keeper function Dec 7, 2022
@inchori inchori marked this pull request as draft December 7, 2022 02:47
@inchori
Copy link
Author

inchori commented Dec 7, 2022

When the #520 merged, I'll re-open this PR.

@inchori inchori marked this pull request as ready for review December 7, 2022 05:12
audtlr24
audtlr24 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xHansLee
0xHansLee approved these changes Dec 7, 2022
View reviewed changes
x/datadeal/keeper/deal.go Outdated Show resolved Hide resolved
x/datadeal/keeper/deal.go Outdated Show resolved Hide resolved
youngjoon-lee
youngjoon-lee approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/datadeal/keeper/deal.go Outdated Show resolved Hide resolved
x/datadeal/keeper/deal.go Outdated Show resolved Hide resolved
gyuguen
gyuguen reviewed Dec 8, 2022
View reviewed changes
x/datadeal/keeper/deal.go Outdated Show resolved Hide resolved
@inchori inchori merged commit b0ef3d5 into main Dec 8, 2022
@inchori inchori deleted the ft/512/create_deal_keeper branch December 8, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Implement CreateDeal tx and Query a Deal
5 participants
@inchori @youngjoon-lee @gyuguen @audtlr24 @0xHansLee