Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add-genesis-oracle CLI #536

Merged
merged 7 commits into from
Dec 12, 2022
Merged

feat: add-genesis-oracle CLI #536

merged 7 commits into from
Dec 12, 2022

Conversation

0xHansLee
Copy link
Contributor

close #531

Implementation of add-genesis-oracle CLI.

@0xHansLee 0xHansLee added this to the v2.1.0-beta milestone Dec 8, 2022
@0xHansLee 0xHansLee self-assigned this Dec 8, 2022
gyuguen
gyuguen approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

youngjoon-lee
youngjoon-lee reviewed Dec 8, 2022
View reviewed changes
cmd/panacead/cmd/genoracle.go Outdated Show resolved Hide resolved
cmd/panacead/cmd/genoracle.go Outdated Show resolved Hide resolved
youngjoon-lee
youngjoon-lee approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

inchori
inchori approved these changes Dec 8, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
I left a one comment.

cmd/panacead/cmd/genoracle.go Outdated Show resolved Hide resolved
audtlr24
audtlr24 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
It seems that it can be used for adding genesis Oracle information for testing. However, it seems that we need to use the upgrade handler to add Oracle in the actual running panacea. (Or make proposal for it)

@0xHansLee
Copy link
Contributor Author

It seems that it can be used for adding genesis Oracle information for testing. However, it seems that we need to use the upgrade handler to add Oracle in the actual running panacea. (Or make proposal for it)

Right. We need to make a proposal to register a genesis oracle in mainnet.

@0xHansLee 0xHansLee merged commit 5e7be22 into main Dec 12, 2022
@0xHansLee 0xHansLee deleted the ft/531/gen-oracle-cli branch December 12, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@0xHansLee 0xHansLee

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Implement initial Oracle Registration
5 participants
@0xHansLee @youngjoon-lee @gyuguen @audtlr24 @inchori