Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement dataDeal query client #539

Merged
merged 1 commit into from
Dec 12, 2022
Merged

feat: implement dataDeal query client #539

merged 1 commit into from
Dec 12, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Dec 8, 2022

close #537

@gyuguen gyuguen added this to the v2.1.0-beta milestone Dec 8, 2022
@gyuguen gyuguen self-assigned this Dec 8, 2022
@gyuguen gyuguen linked an issue Dec 8, 2022 that may be closed by this pull request
Add CLI: DataDeal Query #537
Closed
0xHansLee
0xHansLee reviewed Dec 8, 2022
View reviewed changes
x/datadeal/keeper/grpc_query_deal.go Outdated Show resolved Hide resolved
x/datadeal/keeper/grpc_query_deal.go Outdated Show resolved Hide resolved
inchori
inchori approved these changes Dec 8, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

youngjoon-lee
youngjoon-lee approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xHansLee
0xHansLee approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from ft/513/implement_submit_consent to main December 12, 2022 06:26
@gyuguen gyuguen force-pushed the ft/537/implement_data_deal_query branch from cf51b8e to 04520b3 Compare December 12, 2022 07:08
@gyuguen gyuguen merged commit df84689 into main Dec 12, 2022
@gyuguen gyuguen deleted the ft/537/implement_data_deal_query branch December 12, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@gyuguen gyuguen

Labels
x/datadeal
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Add CLI: DataDeal Query
5 participants
@gyuguen @youngjoon-lee @audtlr24 @0xHansLee @inchori