Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added decrypt cli #545

Merged
merged 7 commits into from
Dec 13, 2022
Merged

feat: added decrypt cli #545

merged 7 commits into from
Dec 13, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Dec 12, 2022

close #514

@gyuguen gyuguen added this to the v2.1.0-beta milestone Dec 12, 2022
@gyuguen gyuguen self-assigned this Dec 12, 2022
0xHansLee
0xHansLee approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I saw the TODO, but I think it's good to keep this way. Could you explain why do you think that?

@gyuguen
Copy link
Contributor Author

gyuguen commented Dec 13, 2022

LGTM I saw the TODO, but I think it's good to keep this way. Could you explain why do you think that?

We know the oracle endpoint from the oracle store, we can provide enough encryptedCombinedKey to fetch on our own.
I think we can get oracleAddress and get encryptionCombinedKey from it.

But it just only comfort.

inchori
inchori approved these changes Dec 13, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I left a not important comment.

cmd/panacead/cmd/root.go Outdated Show resolved Hide resolved
audtlr24
audtlr24 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuguen gyuguen merged commit 6197a45 into main Dec 13, 2022
@gyuguen gyuguen deleted the ft/514/decrypt_cli branch December 13, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inchori inchori inchori approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

Assignees

@gyuguen gyuguen

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Add CLI: decrypt
4 participants
@gyuguen @audtlr24 @0xHansLee @inchori