Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add an encrypted_oracle_priv_key in oracleRegistration #546

Merged
merged 6 commits into from
Dec 12, 2022
Merged

refactor: add an encrypted_oracle_priv_key in oracleRegistration #546

merged 6 commits into from
Dec 12, 2022

Conversation

inchori
Copy link

@inchori inchori commented Dec 12, 2022

Closes #544

  • Add an encrypted_oracle_priv_key field in oracleRegistration.

@inchori inchori added this to the v2.1.0-beta milestone Dec 12, 2022
@inchori inchori self-assigned this Dec 12, 2022
gyuguen
gyuguen approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xHansLee
0xHansLee approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/oracle/keeper/oracle.go Show resolved Hide resolved
youngjoon-lee
youngjoon-lee approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inchori inchori merged commit 46f80bb into main Dec 12, 2022
@inchori inchori deleted the ft/544/add_oracle_key_registration branch December 12, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@inchori inchori

Labels
x/oracle
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Add a EncryptedOraclePrivatKey field in OracleRegistration
5 participants
@inchori @youngjoon-lee @gyuguen @audtlr24 @0xHansLee