Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add event an uniqueID at approveOracleRegistration #549

Merged
merged 4 commits into from
Dec 14, 2022
Merged

feat: add event an uniqueID at approveOracleRegistration #549

merged 4 commits into from
Dec 14, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Dec 13, 2022

Related to issue

@gyuguen gyuguen added this to the v2.1.0-beta milestone Dec 13, 2022
@gyuguen gyuguen requested a review from cl9200 as a code owner December 13, 2022 08:45
@gyuguen gyuguen self-assigned this Dec 13, 2022
@gyuguen gyuguen linked an issue Dec 13, 2022 that may be closed by this pull request
Implement ApproveOracleRegistration tx #510
Closed
youngjoon-lee
youngjoon-lee approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xHansLee
0xHansLee approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

inchori
inchori approved these changes Dec 14, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuguen gyuguen merged commit 7368e36 into main Dec 14, 2022
@gyuguen gyuguen deleted the ft/na/add_event_unique_id_at_approve_oracle_registration branch December 14, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@gyuguen gyuguen

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Implement ApproveOracleRegistration tx
5 participants
@gyuguen @youngjoon-lee @audtlr24 @0xHansLee @inchori