Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change signer to provider address in sumbit consent msg #550

Merged
merged 2 commits into from
Dec 14, 2022
Merged

fix: change signer to provider address in sumbit consent msg #550

merged 2 commits into from
Dec 14, 2022

Conversation

0xHansLee
Copy link
Contributor

This PR is based on #548.

Changed the signer of MsgSubmitConsent from OracleAddress to ProviderAddress

@0xHansLee 0xHansLee added this to the v2.1.0-beta milestone Dec 14, 2022
@0xHansLee 0xHansLee self-assigned this Dec 14, 2022
audtlr24
audtlr24 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, It seems that the variable name also needs to be changed.

x/datadeal/types/message_deal.go Outdated Show resolved Hide resolved
inchori
inchori approved these changes Dec 14, 2022
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

youngjoon-lee
youngjoon-lee approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

gyuguen
gyuguen approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit c63fb9d into ft/na/submit_consent_cli Dec 14, 2022
@0xHansLee 0xHansLee deleted the fix/na/submit_consent_signer branch December 14, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@inchori inchori inchori approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200

Assignees

@0xHansLee 0xHansLee

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.
5 participants
@0xHansLee @youngjoon-lee @gyuguen @audtlr24 @inchori