Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CLI for issuing JWT #565

Merged
merged 5 commits into from
Dec 22, 2022
Merged

feat: add CLI for issuing JWT #565

merged 5 commits into from
Dec 22, 2022

Conversation

inchori
Copy link

@inchori inchori commented Dec 21, 2022 •
edited
Loading

Closes #558

FYI)

  • You can test like this:
panacead issue-jwt consumer 1h

@inchori inchori added this to the Protocol Documentation milestone Dec 21, 2022
@inchori inchori self-assigned this Dec 21, 2022
0xHansLee
0xHansLee reviewed Dec 22, 2022
View reviewed changes
cmd/panacead/cmd/jwt.go Outdated Show resolved Hide resolved
gyuguen
gyuguen approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please check my comment.

cmd/panacead/cmd/jwt.go Outdated Show resolved Hide resolved
0xHansLee
0xHansLee approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@inchori inchori merged commit 70e3af7 into main Dec 22, 2022
@inchori inchori deleted the ft/558/add_jwt_cli branch December 22, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@gyuguen gyuguen gyuguen approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Add CLI: panacead jwt ...
4 participants
@inchori @gyuguen @audtlr24 @0xHansLee