-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Cosmos SDK to v0.37.15 #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2020
youngjoon-lee
commented
Sep 29, 2020
youngjoon-lee
commented
Sep 29, 2020
youngjoon-lee
commented
Sep 29, 2020
youngjoon-lee
commented
Sep 29, 2020
youngjoon-lee
force-pushed
the
ft/na/fresh
branch
3 times, most recently
from
October 13, 2020 09:15
1245960
to
79825ff
Compare
youngjoon-lee
changed the title
Bump Cosmos SDK version to
Upgrade Cosmos SDK to Oct 14, 2020
v0.37.14-internal
+ related changesv0.37.14-internal
+ related changes
cl9200
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
youngjoon-lee
changed the title
Upgrade Cosmos SDK to
Upgrade Cosmos SDK to v0.37.15
Oct 15, 2020
v0.37.14-internal
+ related changes
I also tested all commands in our manual. All works well. I'd say this PR is safe to be merged. |
youngjoon-lee
force-pushed
the
ft/na/fresh
branch
from
October 15, 2020 06:46
e207931
to
503f9ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
Changes
There are so many breaking changes when upgrading
medibloc/cosmos-sdk
from v0.34.7 to v0.37.15.Most of boilerplate codes were moved into the cosmos-sdk. So, many Go packages were removed from the panacea-core.
app/app.go
andcmd/**/main.go
, but most of them are straight-forward fortunately.app/genesis.go
were moved to themedibloc/cosmos-sdk
repo. Please see Modify default genesis params for Panacea cosmos-sdk#3.The
x/**/module.go
was added.x/
) must implementAppModuleBasic
andAppModule
, so that they can be managed byModuleManager
. (link)The
x/**/keeper.go
and some keeper-related codes were moved into thex/**/keeper/
, according to the new recommended directory structure.The genesis-related types were moved into the
x/**/types/
, according to the new recommended directory structure.Tests
panacead
from scratch